fix(driver-memory): a resolved dateRange window's upper bound is exclusive, so 'today' stops before tomorrow - #16966

Fixes #16179

Clause-②: no

Route 2, as triage settled it: fix what the relative tokens emit, and leave an explicit dateRange: [a, b] alone.

The defect, re-measured

parseDateRangeString('today') returns the day's start instant and the next day's start instant. The analytics call site compared that upper bound with $lte, because nextUtcCalendarDay widens only a bare YYYY-MM-DD and returns null for a full timestamp, so the half-open branch was never taken. 'today' was therefore one day plus one instant long: two adjacent day windows overlapped at midnight and a row stamped exactly there was counted in both.

Driven end to end through MemoryAnalyticsService.query() against the built package, the double-count as a number rather than an argument — the same row, the same table, asked on two consecutive days:

AssertionError: a row must belong to exactly one day — 2 is the double-count this card is about: expected 2 to be 1
- Expected   1
+ Received   2

The repair

parseDateRangeString now returns the window and what its upper bound means, and only a window this driver resolved is compared with $lt:

• 'today' marks its end exclusive — it is where tomorrow begins, the one instant the day must not contain;
• an explicit [a, b] is marked inclusive, i.e. untouched;
• a bare YYYY-MM-DD end keeps its whole-day widening to < nextUtcCalendarDay(day) (driver-memory / driver-mongodb：裸日期 $lte 上界在 datetime 值上同样丢当天数据（#3777 的非 SQL 驱动对齐） #4042; the SQL twin is dashboard 的日期区间上界打在 datetime 列上丢失当天数据 —— 默认配置即命中 #3777);
• the last N … leg keeps $lte: its end is the current instant, a moment the window reaches rather than one it stops before.

The union's two arms are discriminated by Array.isArray one line above the bound construction, so the token path and the explicit-array path never had to share an answer. ⇒ the escalation clause did not fire.

⚠️ The other spelling of route 2 — having the token emit a bare YYYY-MM-DD end — is not available on this path, and its failure would have been silent. boundary() renders the query timezone's midnight instant; a bare day would be widened and then cut at T00:00:00Z, i.e. at UTC midnight, undoing #16042 for every non-UTC caller. Measured on Asia/Shanghai: the correct window ends at 2026-09-06T16:00:00.000Z, and the bare-day route would end it eight hours late.

⭐ The control: the explicit array is identical to the character

Triage's second acceptance half is a measurement, not an assertion. The card's own three-row fixture, through the built package's public entry, before and after the repair:

The published type surface is byte-identical too: dist/index.d.ts sha256 2be0755c20d8eadf59938f00ddf78f97c69642c84607f6ef7935fff4a31ad476 with the fix and with memory-analytics.ts reverted to origin/main and rebuilt. No exported symbol, no option key — the carrier is unchanged.

Ablation

Mutation: endExclusive: true → false in the 'today' branch — the minimal restoration of the defect, leaving the array path alone. On-disk proof each leg: occurrence counts of the exact texts flipped 1→0 and 0→1, and the blob hash moved off the HEAD blob (0315a768… → 22c7fdaf…). Restore verified by blob-hash equality and an empty git diff HEAD, under an EXIT INT TERM trap on absolute paths.

Predicted direction: red on the token leg, green on the explicit-array leg. Observed, at HEAD 17921d98d5:

Tests  18 failed | 12 passed (30)

The 18 are exactly the token assertions (8 boundary-row + 8 two-arms-differ + 2 partition). The 12 that stay green include all 8 explicit-array control cases; re-run alone under the same mutation they are 8 passed | 22 skipped. That is the route-1 tripwire: a repair that made $lt unconditional reddens there, not here.

⚠️ The first ablation attempt is NOT MEASURED, not a red: it carried --reporter=basic, which vitest 4 tried to load as a custom reporter module (ERR_LOAD_URL), so the suite never started. Re-run without it.

Verification

Exit codes captured by redirect-then-$?, never across a pipe.

COVERAGE — gates derived with node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack on the final head 17921d98d5 (change set: the 3 files in this PR; identical to the derivation taken before the last commit). All 55 invoked; reconciled with --ran:

✓ dispatch-gates --ran: 55 derived famil(ies) accounted for — 55 run, 0 NOT-MEASURED.

VERDICTS — stated separately from coverage, because they are not the same fact:

• 53 green.
• 2 NOT MEASURED, exit 3 PREREQUISITE NOT MET — ⛔ neither is a pass: pnpm check:dual-build-cjs-loads (81 packages have no dist/) and pnpm check:type-check-debt (27 workspace deps of the ledgered packages have no built type entry point). Both demand a whole-monorepo build closure, which is a repo-wide run CI owns; declared to CI, and no ledger number is read from either.
• 0 red.

Package-level, under the shared verify lock:

The new pin file is reached by the package's tsconfig.json (tsc --listFiles), so its typecheck is not blind to it.

Anchors, re-measured, with the tree named

Every anchor below was taken on the worktree /home/user/objectstack-issue-16179 at 97adce2faa9d27d7811f1f299f5ed806a467f624, which is origin/main. Triage did not re-check any of them.

The premise holds. 'today' is in DATE_RANGE_PRESETS, so it survives the closed vocabulary and reaches the resolver — the token path is live.

验收备注

• Noted, already filed as Analytics drivers (memory, SQL) align dateRange string handling to the closed preset vocabulary (driver half of #16041) #16322 — ⛔ not touched here, ⛔ not merged in. parseDateRangeString matches range.startsWith('last ') (a space), while the declared vocabulary spells its presets last_7_days / last_30_days / last_90_days. Every preset except 'today' therefore falls to the [range, range] fallback today. That is squarely inside Analytics drivers (memory, SQL) align dateRange string handling to the closed preset vocabulary (driver half of #16041) #16322's declared scope (driver half of driver-memory analytics silently accepts an unparseable dateRange and matches EVERY row — and the platform's own documented spelling 'Last 7 days' is one of them #16041, currently pm:blocked), so no new card. Analytics drivers (memory, SQL) align dateRange string handling to the closed preset vocabulary (driver half of #16041) #16322 is not addressed by this PR and stays open.
• Observation, not filed — the card's :760 anchor is 6 lines stale on origin/main; the shape it quotes is correct.
• Observation, not filed — check:dual-build-cjs-loads and check:type-check-debt both need a whole-monorepo build before they can render any verdict at all. Infrastructure prerequisite, not a defect.
• ⛔ Out of scope and untouched: driver-memory analytics silently accepts an unparseable dateRange and matches EVERY row — and the platform's own documented spelling 'Last 7 days' is one of them #16041 (an unparseable dateRange matching every row — this PR is about a parsed window's boundary), driver-memory analytics accepts timeDimensions[].granularity and never buckets by it — one group per distinct timestamp #16178 (grouping), driver-memory analytics resolves a string dateRange without ever reading the declared AnalyticsQuery.timezone #16042 (which calendar anchors the window). None of them is addressed here.

Changeset

patch, measured rather than assumed: @objectstack/driver-memory is 17.3.0 with real exports, publishConfig.access: public, no private: true, and it sits in .changeset/config.json's fixed group with ignore: []. It publishes ⇒ a bug fix in it takes a patch changeset and ⛔ never skip-changeset — AGENTS.md :1036 on origin/main.

Generated by Claude Code